This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH] Remus breaks the build

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "Xen-devel@xxxxxxxxxxxxxxxxxxx" <Xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] Remus breaks the build
From: Brendan Cully <brendan@xxxxxxxxxx>
Date: Wed, 18 Aug 2010 13:09:15 -0700
Delivery-date: Wed, 18 Aug 2010 13:09:44 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100813194400.GB6981@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "Xen-devel@xxxxxxxxxxxxxxxxxxx" <Xen-devel@xxxxxxxxxxxxxxxxxxx>
References: <4C6493ED.3040605@xxxxxxxx> <1281695884.3170.676.camel@xxxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1008131254280.2545@kaball-desktop> <19557.16422.38625.558018@xxxxxxxxxxxxxxxxxxxxxxxx> <20100813194400.GB6981@xxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2010-03-22)
On Friday, 13 August 2010 at 12:44, Brendan Cully wrote:
> On Friday, 13 August 2010 at 13:52, Ian Jackson wrote:
> > Stefano Stabellini writes ("[Xen-devel] Re: [PATCH] Remus breaks the 
> > build"):
> > > I'll apply the patch for now, of course I am more then willing to
> > > re-enable remus as soon as the problem is fixed.
> > 
> > Quite so.  I have also removed remus from the nightly tests (since
> > otherwise this would be regarded as a regression in the cases where
> > remus still sort of worked; it hasn't worked properly for some time).
> As always, Ian, it would be better if you provided some kind of
> concrete bug report instead vaguely saying "it doesn't work". I've
> never received one.

It turns out it was broken... by you, in 21488:dd6bbdc42033 (I missed
this because I've been running the 4.0 tree until recently). That
patch of yours only appeared to be a no-op, because it missed several
calls to read_exact. I've patchbombed the fix.

Xen-devel mailing list