This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] Remus breaks the build

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] Remus breaks the build
From: Brendan Cully <brendan@xxxxxxxxx>
Date: Fri, 13 Aug 2010 12:42:17 -0700
Cc: "Xen-devel@xxxxxxxxxxxxxxxxxxx" <Xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 13 Aug 2010 12:42:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C6493ED.3040605@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>, "Xen-devel@xxxxxxxxxxxxxxxxxxx" <Xen-devel@xxxxxxxxxxxxxxxxxxx>
References: <4C6493ED.3040605@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2010-03-22)
On Thursday, 12 August 2010 at 17:38, Jeremy Fitzhardinge wrote:
>  Remus tries to go out of the tools directory and build in the kernel
> directory.  This assumes that we're actually building a kernel out of
> the xen build tree, and that kernel is actually being used.
> If Remus needs kernel modules, they should actually be part of the
> respective kernel trees, not grafted on post-facto.
> Disable the tools/remus directory until this is sorted out.
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>

I assume you're talking about this snippet of tools/remus/kmod/Makefile:

$(MAKE) -C $(KERNELDIR) SUBDIRS=`pwd` modules

which expects to find a Makefile in $KERNELDIR but does the actual
building in place, in the tools/remus/kmod directory (unless the
kernel build system has changed recently?). I thought this was a
pretty standard way to build out-of-tree kernel modules.

I'm not sure why this is causing you problems (is it?), but if you're
willing to carry sch_queue in the pvops tree, I'd be happy to drop
tools/remus/kmod in the unstable tree.

Xen-devel mailing list