This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] hotplug: 21549:8bcaec29574e breaks vif-script wi

To: Brendan Cully <brendan@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] hotplug: 21549:8bcaec29574e breaks vif-script with arguments
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Wed, 18 Aug 2010 14:51:08 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 18 Aug 2010 06:51:58 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <74b9fe513d8591ca1423.1282083230@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <74b9fe513d8591ca1423.1282083230@xxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Brendan Cully writes ("[Xen-devel] [PATCH] hotplug: 21549:8bcaec29574e breaks 
vif-script with arguments"):
> hotplug: 21549:8bcaec29574e breaks vif-script with arguments.
> For example, (vif-script 'vif-bridge bridge=eth1') in xend-config.sxp will
> cause vif-setup to attempt to execute 'vif-bridge bridge=eth1' due to a
> quoting mismatch. The fix appears to be to remove the extra quotes around
> "$script" in vif-setup.

The question is whether the argument is supposed to be a sh syntax
command or the name of an executable which latter might contain

I think your intererpretation (the former) is better, and it's what we
had before, so I have applied your patch.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>