WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] hotplug: 21549:8bcaec29574e breaks vif-script with a

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] hotplug: 21549:8bcaec29574e breaks vif-script with arguments
From: Brendan Cully <brendan@xxxxxxxxx>
Date: Tue, 17 Aug 2010 15:13:50 -0700
Delivery-date: Tue, 17 Aug 2010 15:14:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.5.2+5-0c8646292ca4
# HG changeset patch
# User Brendan Cully <brendan@xxxxxxxxx>
# Date 1282083158 25200
# Node ID 74b9fe513d8591ca14233590062079b042abb68d
# Parent  774dfc178c39bd3fe2ec14b4f96e60b78391b397
hotplug: 21549:8bcaec29574e breaks vif-script with arguments.

For example, (vif-script 'vif-bridge bridge=eth1') in xend-config.sxp will
cause vif-setup to attempt to execute 'vif-bridge bridge=eth1' due to a
quoting mismatch. The fix appears to be to remove the extra quotes around
"$script" in vif-setup.

Signed-off-by: Brendan Cully <brendan@xxxxxxxxx>

diff --git a/tools/hotplug/Linux/vif-setup b/tools/hotplug/Linux/vif-setup
--- a/tools/hotplug/Linux/vif-setup
+++ b/tools/hotplug/Linux/vif-setup
@@ -2,7 +2,7 @@
 
 if test "$script"
 then
-    exec "$script" $*
+    exec $script $*
 else
     exec /etc/xen/scripts/vif-bridge $*
 fi

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>