This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xen: fix MSR xentrace output

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen: fix MSR xentrace output
From: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Date: Wed, 4 Aug 2010 09:40:29 +0100
Cc: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 04 Aug 2010 01:42:44 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=wq8ic4Cs+CqJmkTLjR/1IsZwXGaZX3ub8Mk5KwIwPok=; b=RYBzjA8x4IRe4m4m+pIlGNaurck6U9fPfAoY84x0R54gIHK7NAA3hBlqRQV/3WsAA1 iKb80V4N6Dtx405ogXbDtgY8mjSWhT1qPwIT8EXxropXBntuEn+Zrjuu1fx6ryAvmclE YPAAU3Axw/CZ2BbWeVJAfO6Wt/vCyPsmmRHJM=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=O+LpW5Ld3gHS+qsN1GxlpA+q41hq3ssihpidWcpvTtoHgrcPbNEVRoQoRvuC+RAKZP P807v9DCbfNJzkSZwmW/cKyifuVGI1tk5pc4GqlCiS1Q/lM1GLplJLRTZvbYgwdOiflS RRIqPgQcjShVUHEBzQ3SdKzBIwmy/afadjQTg=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C87E08FD.1C9A5%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AANLkTimqURaNHxP75i3HUibAc=QTdX-tqw+momUV9_=Q@xxxxxxxxxxxxxx> <C87E08FD.1C9A5%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Ah, I see -- when I added the MSR tracing to hvm.c, I didn't realize
that there were still MSR traces in the svm/vmx files.  Mea culpa --
duplicated trace values are bad, and having inconsistent ordering for
the parameters in the traces is unacceptable.

I withdraw my NACK.


On Tue, Aug 3, 2010 at 5:57 PM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> wrote:
> Well, some of the various MSR_READ/WRITE traces are wrong one way or the
> other. The vmx/svm-specific trace points have since the beginning of time
> been ordered msr_index,msr_low,msr_high. It's the new trace points added by
> you to hvm.c that are the 'novel' way round (msr_low,msr_high,msr_index).
> Also the proliferation of trace points is stupid: the vmx/svm-specific ones
> could easily be got rid of and be on a common exit path from the hvm-generic
> intercept functions instead. The movement and duplication of the MSR_WRITE
> trace points in Christoph's patch is especially egregious, as the
> svm/vmx-specific trace points can simply be deleted.
>  -- Keir
> On 03/08/2010 17:39, "George Dunlap" <dunlapg@xxxxxxxxx> wrote:
>> NACK for discussion.
>> What do you mean they're "mixed up"?  Putting the 64-bit value first
>> makes it easy to define a structure you can just point directly at the
>> binary data.  If xentrace_format is different, wouldnt' it be easier
>> to change it than the hypervisor?
>>  -George
>> On Tue, Aug 3, 2010 at 5:24 PM, Christoph Egger <Christoph.Egger@xxxxxxx>
>> wrote:
>>> Hi!
>>> Attached patch corrects MSR read/write trace output.
>>> Also avoid duplicate MSR read/write lines in xentrace output.
>>> MSR and value are mixed up.
>>> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
>>> --
>>> ---to satisfy European Law for business letters:
>>> Advanced Micro Devices GmbH
>>> Einsteinring 24, 85609 Dornach b. Muenchen
>>> Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
>>> Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
>>> Registergericht Muenchen, HRB Nr. 43632
>>> _______________________________________________
>>> Xen-devel mailing list
>>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>>> http://lists.xensource.com/xen-devel

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>