Re: [Xen-devel] [PATCH] xen: fix MSR xentrace output

[George Dunlap <dunlapg@xxxxxxxxx>]

And, why are you moving the trace things around?  In the write case,
you're pointlessly duplicating code.

I can see the point of adding a case for failed reads, so you can see
what the msr address was that failed.  But in that case I'd probably
trace a value of 0 or -1 for msr content.

 -George

On Tue, Aug 3, 2010 at 5:39 PM, George Dunlap <dunlapg@xxxxxxxxx> wrote:
> NACK for discussion.
>
> What do you mean they're "mixed up"?  Putting the 64-bit value first
> makes it easy to define a structure you can just point directly at the
> binary data.  If xentrace_format is different, wouldnt' it be easier
> to change it than the hypervisor?
>
>  -George
>
>
> On Tue, Aug 3, 2010 at 5:24 PM, Christoph Egger <Christoph.Egger@xxxxxxx> 
> wrote:
>>
>> Hi!
>>
>> Attached patch corrects MSR read/write trace output.
>> Also avoid duplicate MSR read/write lines in xentrace output.
>> MSR and value are mixed up.
>>
>> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
>>
>> --
>> ---to satisfy European Law for business letters:
>> Advanced Micro Devices GmbH
>> Einsteinring 24, 85609 Dornach b. Muenchen
>> Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
>> Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
>> Registergericht Muenchen, HRB Nr. 43632
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel
>>
>>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel