This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xen: fix MSR xentrace output

To: Christoph Egger <Christoph.Egger@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen: fix MSR xentrace output
From: George Dunlap <dunlapg@xxxxxxxxx>
Date: Tue, 3 Aug 2010 17:48:21 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Tue, 03 Aug 2010 09:49:07 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=ynflE/fxjGUlVcmZxfykwWFB8dGHl60moWGakmMQKIk=; b=Wp8sVP72HCHkS/Vcy8Tcv8ipCZlqjuwfY7NsiLDJGlvxBcjjQ8SA5JWLYR0AX5XoVs FFMwudOCk7/K38eVxtBjVROKlSf8mOHUILbXUUBQdkne8NdjZqDK7rOUWv1MUMKXu6p4 JjrqQwMQkqw1UWs424AhMxN5vi81zNWeI3H5A=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=O9m51LaTC3vAdeaQEwtO3NTEk83T7kNAD9HjYse2lZNrq3wb9fBZvVyfAKTJrgqTDp Xh4nV7d/neA279KOqrGPE/lgrjjTOv7/QJ3PhTsjFTR4XJ/Y+0YkkHBSGYo/lE2ueYcS d7sSuXd3CAMGVPKGLVmSs5N69p0zKLvU4KoOw=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTimqURaNHxP75i3HUibAc=QTdX-tqw+momUV9_=Q@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201008031824.21390.Christoph.Egger@xxxxxxx> <AANLkTimqURaNHxP75i3HUibAc=QTdX-tqw+momUV9_=Q@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
And, why are you moving the trace things around?  In the write case,
you're pointlessly duplicating code.

I can see the point of adding a case for failed reads, so you can see
what the msr address was that failed.  But in that case I'd probably
trace a value of 0 or -1 for msr content.


On Tue, Aug 3, 2010 at 5:39 PM, George Dunlap <dunlapg@xxxxxxxxx> wrote:
> NACK for discussion.
> What do you mean they're "mixed up"?  Putting the 64-bit value first
> makes it easy to define a structure you can just point directly at the
> binary data.  If xentrace_format is different, wouldnt' it be easier
> to change it than the hypervisor?
>  -George
> On Tue, Aug 3, 2010 at 5:24 PM, Christoph Egger <Christoph.Egger@xxxxxxx> 
> wrote:
>> Hi!
>> Attached patch corrects MSR read/write trace output.
>> Also avoid duplicate MSR read/write lines in xentrace output.
>> MSR and value are mixed up.
>> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
>> --
>> ---to satisfy European Law for business letters:
>> Advanced Micro Devices GmbH
>> Einsteinring 24, 85609 Dornach b. Muenchen
>> Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
>> Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
>> Registergericht Muenchen, HRB Nr. 43632
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel

Xen-devel mailing list