This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 0 of 3] libxl: memory leaks

To: Ian Campbell <ian.campbell@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0 of 3] libxl: memory leaks
From: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Date: Mon, 2 Aug 2010 14:11:43 +0100
Cc: Ian, Campbell <Ian.Campbell@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 02 Aug 2010 06:15:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <patchbomb.1280752270@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1280752270@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2010-08-02 at 13:31 +0100, Ian Campbell wrote:
> The following fix a few memory leaks.
> The first was discussed on list and it was decided that although it
> wasn't a real leak, since the memory is allocated exactly once per
> thread and is correctly cleaned up on pthread_exit(), it was still
> useful for xl (a non-threaded application) to be able to be completely
> valgrind clean for the purposes of auditing libxl.
> The leaks fixed in xl create are just a subset since I didn't delve
> into recursively freeing the types defined by libxl yet. There are
> also leaks in the lexer and parser which I didn't tackle yet.

These patches are all good news. You should be aware (if not already)
that we have a plan for dealing with the majority of remaining leaks, I
was going to implement it after my current PCI work. So if you are going
to go all the way with this we should talk... :)


Xen-devel mailing list