Re: [Xen-devel] [XEN][vNUMA][PATCH 7/9] Build NUMA HVM

[Dulloor <dulloor@xxxxxxxxx>]

On Tue, Jul 6, 2010 at 3:09 AM, George Dunlap
<George.Dunlap@xxxxxxxxxxxxx> wrote:
> You mean, if NUMA is on, then PoD is disabled, but if NUMA is off, PoD
> still works?

Yes. Only if we choose a NUMA allocation strategy for a guest, PoD is
disabled for it.
Otherwise things are the same as now. I plan to take care of PoD with
NUMA allocation
once this series is checked-in.

>
> Or do you mean, this patch will break PoD functionality if accepted?
>
>  -George
>
> On Tue, Jul 6, 2010 at 7:07 AM, Dulloor <dulloor@xxxxxxxxx> wrote:
>> WIth the NUMA allocator, pod is simply disabled as of now. This debug
>> statement seeped through when testing that. Will take care of it :)
>> However, I did test PoD for any regressions.
>>
>> -dulloor
>>
>> On Mon, Jul 5, 2010 at 2:55 AM, George Dunlap
>> <George.Dunlap@xxxxxxxxxxxxx> wrote:
>>> What's this line for:
>>>
>>>>+    if (nr_pages > target_pages)
>>>>     {
>>>>-        PERROR("Could not allocate memory.");
>>>>-        goto error_out;
>>>>+        pod_mode = 1;
>>>>+        mem_flags |= XENMEMF_populate_on_demand;
>>>>+        IPRINTF("I SHOULDN'T BE HERE !!\n");
>>>
>>> It's not clear what this patch does to the PoD logic... does it still
>>> need some work, or should I try harder to grok it?  Have you tested it
>>> in PoD mode?
>>>
>>>  -George
>>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel
>>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel