xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] svm: debug improvements

from [Christoph Egger]

[Permanent Link][Original]

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	Re: [Xen-devel] [PATCH] svm: debug improvements
From:	Christoph Egger <Christoph.Egger@xxxxxxx>
Date:	Thu, 24 Jun 2010 12:33:16 +0200
Cc:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date:	Thu, 24 Jun 2010 03:36:22 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<C847CF3C.184AB%keir.fraser@xxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<C847CF3C.184AB%keir.fraser@xxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	KMail/1.9.10

On Wednesday 23 June 2010 15:48:28 Keir Fraser wrote:
> On 23/06/2010 13:49, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
> > Attached patch moves vmcb dump function into
> > its own svm debug files.
> > Add svm_vmcb_isvalid() to svm code to validate
> > the vmcb.
>
> I won't take patches to add things that aren't used. Unless they are used
> later in the same patch series,

Yes, that is the case. It will be used in the nested virtualization patch 
series. Do you prefer me to resend it as part of the patch series?

> all posted with intention to be applied at 
> the same time. Otherwise the function is dead code, and I love to delete
> dead code.

Me, too.

Christoph

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] svm: debug improvements, Christoph Egger Re: [Xen-devel] [PATCH] svm: debug improvements, Keir Fraser Re: [Xen-devel] [PATCH] svm: debug improvements, Christoph Egger <= Re: [Xen-devel] [PATCH] svm: debug improvements, Keir Fraser

Previous by Date:	[Xen-users] RE: [XCP]: RC1 of XCP 0.5 available for testing, Dave Scott
Next by Date:	[Xen-devel] [PATCH] mce: cleanup, Christoph Egger
Previous by Thread:	Re: [Xen-devel] [PATCH] svm: debug improvements, Keir Fraser
Next by Thread:	Re: [Xen-devel] [PATCH] svm: debug improvements, Keir Fraser
Indexes:	[Date] [Thread] [Top] [All Lists]