Re: [Xen-devel] [PATCH] svm: debug improvements

To:	Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] svm: debug improvements
From:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date:	Wed, 23 Jun 2010 14:48:28 +0100
Cc:
Delivery-date:	Wed, 23 Jun 2010 06:49:33 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<201006231449.41973.Christoph.Egger@xxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcsS0rRDkuTvvh/ZTDef8vdocPpdNgACA3r/
Thread-topic:	[Xen-devel] [PATCH] svm: debug improvements
User-agent:	Microsoft-Entourage/12.24.0.100205

On 23/06/2010 13:49, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> Attached patch moves vmcb dump function into
> its own svm debug files.
> Add svm_vmcb_isvalid() to svm code to validate
> the vmcb.

I won't take patches to add things that aren't used. Unless they are used
later in the same patch series, all posted with intention to be applied at
the same time. Otherwise the function is dead code, and I love to delete
dead code.

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] svm: debug improvements