WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] apic: clean up msr handling

To: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] apic: clean up msr handling
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 11 Jun 2010 16:57:58 +0100
Cc: Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Fri, 11 Jun 2010 08:59:59 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201006111751.49588.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcsJfgkMjxMsaTUUSWO7ami300k/bQAANNyc
Thread-topic: [Xen-devel] [PATCH] apic: clean up msr handling
User-agent: Microsoft-Entourage/12.24.0.100205
On 11/06/2010 16:51, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

>> Hm, I didn't spot that one. It's odd since I thought Christoph was changign
>> macros into inlien functions where possible. Maybe he just changes in
>> whichever direction makes his patch bigger? ;-)
> 
> No, this change has to do with 'smp_processor_id() undefined'.
> The root problem is a circular dependency with inclusion of headers.
> The right fix is to clean up the headers.

Yep, that's what I did.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel