| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH] apic: clean up msr handling
On 11/06/2010 14:40, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
>>>> On 11.06.10 at 15:22, Christoph Egger <Christoph.Egger@xxxxxxx> wrote:
>> -static inline void write_efer(u64 val)
>> -{
>> - this_cpu(efer) = val;
>> - wrmsrl(MSR_EFER, val);
>> -}
>> +#define write_efer(val) do { \
>> + this_cpu(efer) = val; \
>> + wrmsrl(MSR_EFER, val); \
>> +} while(0)
>
> This isn't a good change imo: You now require all current and future
> users of write_efer() to not pass expressions with side effects.
>
> Also, is doesn't really look like a cleanup to me, more like a
> complication.
Hm, I didn't spot that one. It's odd since I thought Christoph was changign
macros into inlien functions where possible. Maybe he just changes in
whichever direction makes his patch bigger? ;-)
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home