WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Balloon driver crash

To: M A Young <m.a.young@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Balloon driver crash
From: Pasi Kärkkäinen <pasik@xxxxxx>
Date: Tue, 8 Jun 2010 13:59:22 +0300
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Dave McCracken <dcm@xxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Delivery-date: Tue, 08 Jun 2010 04:01:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.GSO.2.00.1006081019000.13054@xxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.GSO.2.00.1006031434080.4562@xxxxxxxxxxxxxxxx> <alpine.LFD.2.00.1006032028110.20613@xxxxxxxxxxxxxxx> <1275597402.2782.47.camel@xxxxxxxxxxxxxxxxxxxxx> <201006031738.15635.dcm@xxxxxxxx> <alpine.LFD.2.00.1006072027300.3888@xxxxxxxxxxxxxxx> <1275983765.24218.49851.camel@xxxxxxxxxxxxxxxxxxxxxx> <alpine.GSO.2.00.1006080927520.13054@xxxxxxxxxxxxxxxx> <1275986577.24218.49951.camel@xxxxxxxxxxxxxxxxxxxxxx> <alpine.GSO.2.00.1006081019000.13054@xxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Jun 08, 2010 at 10:25:35AM +0100, M A Young wrote:
> This patch fixes an error in commit f4685d0ed041523d1bd5124c5872459681aca876
> "Add hugepage support to balloon driver" that was causing the balloon  
> driver to crash when shrinking the memory used by Domain-0.
>

Should this be applied to both xen/stable-2.6.31.x and xen/stable-2.6.32.x ? 

-- Pasi

> Signed-off-by: Michael Young <m.a.young@xxxxxxxxxxxx>
>
> --- linux-2.6.32.x86_64/drivers/xen/balloon.c.orig    2010-06-05 
> 22:43:11.000000000 +0100
> +++ linux-2.6.32.x86_64/drivers/xen/balloon.c 2010-06-05 22:47:03.000000000 
> +0100
> @@ -340,7 +340,7 @@
>                               discontig_free = 1;
>
>                       set_phys_to_machine(lpfn, INVALID_P2M_ENTRY);
> -                     if (!PageHighMem(page)) {
> +                     if (!PageHighMem(pfn_to_page(lpfn))) {
>                               ret = HYPERVISOR_update_va_mapping(
>                                       (unsigned long)__va(lpfn << PAGE_SHIFT),
>                                       __pte_ma(0), 0);
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel