WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] libxl/xl: fix multivcpu handling

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxl/xl: fix multivcpu handling
From: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>
Date: Thu, 3 Jun 2010 17:10:45 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 03 Jun 2010 09:12:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1006031552160.3401@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1006031552160.3401@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100515 Icedove/3.0.4
On 03/06/10 15:54, Stefano Stabellini wrote:
Hi all,
currently libxl and xl are incapable of handling multivcpus guests
correctly, this patch fixes it.


Signed-off-by: Stefano Stabellini<stefano.stabellini@xxxxxxxxxxxxx>

---


diff -r 4ab68bf4c37e tools/libxl/libxl.c
--- a/tools/libxl/libxl.c       Thu Jun 03 07:30:54 2010 +0100
+++ b/tools/libxl/libxl.c       Thu Jun 03 15:51:10 2010 +0100
@@ -875,6 +875,14 @@
          if (info->apic) {
              flexarray_set(dm_args, num++, "-acpi");
          }
+        if (info->vcpus) {
+            flexarray_set(dm_args, num++, "-vcpus");
+            flexarray_set(dm_args, num++, libxl_sprintf(ctx, "%d", 
info->vcpus));
+        }

should be either if (info->vcpus > 1) or no test at all and info->vcpus == 0 should return with invalid argument.

--
Vincent

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>