WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] HVM guests are allowed to use the entire virtual

To: Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] HVM guests are allowed to use the entire virtual address space for
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 25 May 2010 17:24:58 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 25 May 2010 09:26:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100525151432.GA15976@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acr8HPvogcmDI5A6RImiuVKoDO0dmQACdUpz
Thread-topic: [Xen-devel] [PATCH] HVM guests are allowed to use the entire virtual address space for
User-agent: Microsoft-Entourage/12.24.0.100205
On 25/05/2010 16:14, "Tim Deegan" <Tim.Deegan@xxxxxxxxxxxxx> wrote:

> At 16:04 +0100 on 25 May (1274803495), Keir Fraser wrote:
>> I think this is already handled correctly by guest_access.h, which is what
>> really matters. Nowadays copy_{to,from}_user (but not __copy_{to,from}_user)
>> are mainly for private usage only by the guest-access macros, and just a few
>> other arch-dependent PV_specific bits of code. Of course the __ versions are
>> still generally useful as 'copy but catch any fault' functions.
> 
> OK, can I suggest the attached change instead?  It brings the
> compat guest-handle macros in line with the normal ones.

Yeah, that's a good bug fix.

 Thanks,
 K.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel