This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] HVM guests are allowed to use the entire virtual

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] HVM guests are allowed to use the entire virtual address space for
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Tue, 25 May 2010 16:14:32 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 25 May 2010 08:21:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C821A5A7.15454%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <0b3b2b31e962561390ca.1274798999@xxxxxxxxxxxxxxxxxxxxxxxx> <C821A5A7.15454%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
At 16:04 +0100 on 25 May (1274803495), Keir Fraser wrote:
> I think this is already handled correctly by guest_access.h, which is what
> really matters. Nowadays copy_{to,from}_user (but not __copy_{to,from}_user)
> are mainly for private usage only by the guest-access macros, and just a few
> other arch-dependent PV_specific bits of code. Of course the __ versions are
> still generally useful as 'copy but catch any fault' functions.

OK, can I suggest the attached change instead?  It brings the 
compat guest-handle macros in line with the normal ones.

Signed-off-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>

There are a few more callers of access_ok() around but at first glance
they seem all to be PV-only. 



Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

Attachment: compat-handle
Description: Text document

Xen-devel mailing list