This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] RE: [PATCH] x86: add CMCI software injection interface

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Frank Van Der Linden <frank.van.der.linden@xxxxxxxxxx>, "Ke, Liping" <liping.ke@xxxxxxxxx>
Subject: RE: [Xen-devel] RE: [PATCH] x86: add CMCI software injection interface
From: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Date: Wed, 5 May 2010 17:07:26 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "Christoph@xxxxxxxxxxxxxxxxxxxx" <Christoph@xxxxxxxxxxxxxxxxxxxx>, Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "gavin.maltby@xxxxxxxxxx" <gavin.maltby@xxxxxxxxxx>
Delivery-date: Wed, 05 May 2010 02:10:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C806F0B8.13549%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <789F9655DD1B8F43B48D77C5D30659731E417B14@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C806F0B8.13549%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcrsBoN8fQDW68zYTYmNSmTGX2PBrwAFER8wAAVuQH8AABeUcA==
Thread-topic: [Xen-devel] RE: [PATCH] x86: add CMCI software injection interface

>-----Original Message-----
>From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
>Sent: Wednesday, May 05, 2010 4:54 PM
>To: Jiang, Yunhong; Frank Van Der Linden; Ke, Liping
>Cc: Christoph@xxxxxxxxxxxxxxxxxxxx; Egger; xen-devel@xxxxxxxxxxxxxxxxxxx;
>Subject: Re: [Xen-devel] RE: [PATCH] x86: add CMCI software injection interface
>On 05/05/2010 08:11, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx> wrote:
>> Maybe another method is to add a new do_mca command for the CMCI, like
>> #define XEN_MC_cmci_inject    6
>> Of course, we can update the interface version, to make the new command will
>> only be supported in new version. So that when new dom0 will not get
>> un-expected result when running in old xen hypervisor.
>To be honest either of these is fine with me. I expect Christoph will prefer
>the former option, but actually so long as older dom0 kernels fail-safe on
>the MCE stuff that would be good by me too. Weird behaviours and odd
>failures from older guests is what we absolutely want to avoid.
>If going with the former option it would be good to think ahead in your
>designs and make sure you end up adding the smallest possible number of new
>XEN_MC_* commands. It could easily become a real mess I'm sure.

"either of these"? Maybe I didn't express my idea clearly. I didn't propose two 
options. I just suggest to use a new command for this purpose. And we can 
update the version number if needed.

BTW, as currently Xen already will return -EINVAL for not-support command (i.e. 
<= 5), maybe the version number update is not needed. ( the -EINVAL may be not 
good as -ENOSYS).

> -- Keir

Xen-devel mailing list