This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: [PATCH] x86: add CMCI software injection interface

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, "gavin.maltby@xxxxxxxxxx" <gavin.maltby@xxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH] x86: add CMCI software injection interface
From: "Ke, Liping" <liping.ke@xxxxxxxxx>
Date: Wed, 5 May 2010 09:56:30 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Christoph
Delivery-date: Tue, 04 May 2010 18:57:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C805DA5D.13417%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <789F9655DD1B8F43B48D77C5D30659731D8B3C40@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C805DA5D.13417%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcrmumtDK0Xxt1gMS26TkfZAaTLaOwE0CwIdABmeNyA=
Thread-topic: [PATCH] x86: add CMCI software injection interface
Hi, Keir

Yes, we do some discussion about the interface compatibility problem before 
But we found the mceinj_cpunr below is defined as unsigned int (not uint32), so 
we think it may have some problem in 32/64 bit machine originally.
So we gave up the backward compatibility effort and made it as uint32_5. But if 
sun/oracle use this interface before, we did have some problem

So Christopher and Gavin, any suggestions for this?


struct xen_mc_mceinject {
-       unsigned int mceinj_cpunr;      /* target processor id */
+       uint32_t mceinj_cpunr;      /* target processor id */
+       uint32_t mceinj_flag;       /* UC error or CE error flag */

-----Original Message-----
From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx] 
Sent: Tuesday, May 04, 2010 9:06 PM
To: Ke, Liping; Jiang, Yunhong
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; Christoph Egger
Subject: Re: [PATCH] x86: add CMCI software injection interface

On 28/04/2010 11:06, "Ke, Liping" <liping.ke@xxxxxxxxx> wrote:

> Hi, all
> Currently we already have MCE software injection interface.
> This small patch now add CMCI software injection interface. So that CMCI error
> could be triggered by software on CPUs which support CMCI.
> Broadcast option is used for simulating bank sharing scenario.
> This patch was tested together by running mcelog in DOM0 and got expected CMCI
> information.

Applied, but then reverted as I realised it appears to change Xen's MCE ABI
without consideration of backward compatibility. Obviously that is not

It seems that generally you guys have issues with the existing machine-check
interfaces, and your inability to modify them now they are a fixed part of
the ABI. Do we need to discuss ways to work around this in a way that
doesn't break older guests?

 -- Keir

Xen-devel mailing list