This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 3/3]xl: Add command description to command table

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3/3]xl: Add command description to command table
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 4 May 2010 17:20:44 +0100
Delivery-date: Tue, 04 May 2010 09:21:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19424.18139.100478.129602@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcrrpJ8htqGlJyQHSci6Q4YMR19VagAAR/e3
Thread-topic: [Xen-devel] [PATCH 3/3]xl: Add command description to command table
User-agent: Microsoft-Entourage/
On 04/05/2010 17:10, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote:

>> +extern struct cmd_spec cmd_table[];
>> +extern int cmdtable_len;
>> +
>>  extern struct libxl_ctx ctx;
>>  extern int logfile;
> This is wrong.  Use of "extern" in this way in a .c file is incorrect;
> pure predeclarations should appear only in .h files, and they should
> appear exactly once each.  That way they can't get out of step.
> I'll send a patch to fix this at some point.

I fixed it before I applied it.

 -- Keir

Xen-devel mailing list