This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 3/3]xl: Add command description to command table

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH 3/3]xl: Add command description to command table
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Tue, 4 May 2010 17:10:03 +0100
Delivery-date: Tue, 04 May 2010 09:12:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BD95035.5090502@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <4BD95035.5090502@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Yang Hongyang writes ("[Xen-devel] [PATCH 3/3]xl: Add command description to 
command table"):
> Add command description to command table

Thanks.  I see this has already been applied.   However:

> diff -r b695c51b8345 -r 25e930534a5d tools/libxl/xl.c
> --- a/tools/libxl/xl.c        Thu Apr 29 23:07:31 2010 +0800
> +++ b/tools/libxl/xl.c        Fri Apr 30 00:16:19 2010 +0800
> @@ -31,6 +31,9 @@
>  #include "xl_cmdimpl.h"
>  #include "xl_cmdtable.h"
> +extern struct cmd_spec cmd_table[];
> +extern int cmdtable_len;
> +
>  extern struct libxl_ctx ctx;
>  extern int logfile;

This is wrong.  Use of "extern" in this way in a .c file is incorrect;
pure predeclarations should appear only in .h files, and they should
appear exactly once each.  That way they can't get out of step.

I'll send a patch to fix this at some point.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>