WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] tmem: fix to 20945 "When tmem is enabled, reserv

To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] tmem: fix to 20945 "When tmem is enabled, reserve a fraction of memory"
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Wed, 17 Feb 2010 12:50:01 +0000
Cc: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 17 Feb 2010 04:53:02 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C7A18D21.A5E2%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4f9cade6-4b13-41fd-bc34-7443fb06ece3@default> <C7A18D21.A5E2%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 17.02.10 13:10 >>>
>On 16/02/2010 18:30, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:
>
>> -    if ( opt_tmem && ((order == 0) || (order >= 9)) &&
>> -         (total_avail_pages <= midsize_alloc_zone_pages) )
>> -        goto fail;
>> +    if ( opt_tmem && (total_avail_pages <= midsize_alloc_zone_pages) )
>> +    {
>> +        if ( order == 0)
>> +            goto try_tmem;
>> +        if ( order >= 9)
>> +            goto fail;
>
>Why not try_tmem in the case that order>=9, too, rather than fail outright?

It could be done that way, but wouldn't have any effect, as tmem
doesn't even try to relinquish any memory when order > 0.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel