Re: [Xen-devel] pvops netconsole

[Brad Plant <bplant@xxxxxxxxxxxx>]

On Fri, 12 Feb 2010 15:09:12 -0800
Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> On 02/04/2010 04:15 PM, Brad Plant wrote:
> > Initialising Xen virtual ethernet driver.
> > blkfront: xvda1: barriers enabled
> > netconsole: local port 11111
> > netconsole: local IP 10.20.40.2
> > netconsole: interface eth1
> > netconsole: remote port 9514
> > netconsole: remote IP 10.20.50.2
> > netconsole: remote ethernet address 00:16:3e:00:50:02
> > netconsole: eth1 doesn't support polling, aborting.
> > netconsole: cleaning up
> >    
> 
> The xen-netfront device doesn't support the polling interface that 
> netconsole relies on.  It probably wouldn't be too hard to add that 
> capability if you want to.  It's independent of the backend and/or the 
> actual underlying hardware device.

Ok, I've come up with something that "works". Patch against 2.6.32.7 is 
attached. While it works, I've got no idea if what I've done is the "right 
way". I used virtio_net.c as a guide.

I've got some issues that I'm stuck on and would like some guidance:

1. When the first message is sent over the net console, the WARN_ONCE() at 
net/core/netpoll.c:327 triggers. I'm not sure what to do about this.

2. When either netconsole is setup or the first message is sent, messages 
already logged to the main console get logged again. Maybe this will go away 
when the above is fixed?

3. Initially netconsole would not initialise because the interface didn't yet 
have a mac address as setup_netfront hadn't yet been called. I changed the 
module_init() in netconsole.c to late_initcall() if !CONFIG_MODULES && 
CONFIG_XEN. Is this allowed and sane?

Cheers,

Brad

xen-netconsole.patch
Description: Text Data

signature.asc
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel