This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Parallel/Serial/Monitor/pyGRUB ReiserFS/others s

To: Daniel Kiper <dkiper@xxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Parallel/Serial/Monitor/pyGRUB ReiserFS/others support/fixes
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 23 Dec 2009 07:50:19 +0000
Delivery-date: Tue, 22 Dec 2009 23:51:00 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20091223005430.GA3449@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqDaqMtLdPC9KKVQF2eAOFIN2kgEgAOe9d1
Thread-topic: [Xen-devel] [PATCH] Parallel/Serial/Monitor/pyGRUB ReiserFS/others support/fixes
User-agent: Microsoft-Entourage/
On 23/12/2009 00:54, "Daniel Kiper" <dkiper@xxxxxxxxxxxx> wrote:

> xen-unstable-hvmloader-strip_20091222.patch:
>   Strip hvmloader after compile. dh_strip from debhelper
>   does not strip binaries without execute attribute.

I don't see the point of doing this. We don't in general strip stuff we
build under tools/, the extra disc space taken is trivial, and symbols can
be convenient to have around. I just don't see the win.
 - Not applying to xen-unstable or xen-3.4

> xen-unstable-parallel-serial-monitor_20091223.patch:

Xend parts look good. The hvmloader parts look unnecessary (since we
currently always declare LPT1 present) and dangerous (Windows guests which
were installed on old Xen iirc get upset if they later boot and see LTP1
not-present in ACPI tables). There'd need to be a *good* reason for hiding
LTP1 in DSDT therefore.
 - Partially applied to unstable; not applied to 3.4

> xen-unstable-pygrub-reiserfs_20091222.patch:
>   Small but important correction for pyGRUB ReiserFS support.
>   Without this patch pyGRUB could not read ReiserFS.

Looks good.
 - Applied to unstable and 3.4.

> xen-unstable-videoram_20091222.patch:
>   Remove videoram option from vfb config.
>   This option is only valid in main config.

Looks good but not critical for 3.4.
 - Applied to unstable; not applied to 3.4.

 -- Keir

Xen-devel mailing list