This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Add memory hotadd to pvops dom0

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Add memory hotadd to pvops dom0
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Sun, 20 Dec 2009 08:04:20 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Sun, 20 Dec 2009 00:04:42 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B2DC6F3.80100@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqBP3J+SrHxkjjlQfm3OEstroJPrgAC5YVS
Thread-topic: [Xen-devel] [PATCH] Add memory hotadd to pvops dom0
User-agent: Microsoft-Entourage/
On 20/12/2009 06:40, "Jeremy Fitzhardinge" <jeremy@xxxxxxxx> wrote:

>>>> +  struct xenpf_mem_hotadd        mem_add;
>>>> uint8_t                        pad[128];
>>> Should the size of the pad be decreased?
>> This is defined by xen hypervisor, and is intended for extenstion in future,
>> I think.
> But Konrad's point is that if you have padding to reserve space for
> future expansion, shouldn't you decrease the padding when you actually
> increase the structure?  Otherwise, if you can arbitrarily grow the
> structure, why do you need padding?

It's a union, dude!

 -- Keir

Xen-devel mailing list