This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Paging and memory sharing for HVM guests

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Paging and memory sharing for HVM guests
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 17 Dec 2009 15:59:30 +0000
Cc: Patrick Colp <pjcolp@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Grzegorz Milos <gm281@xxxxxxxxx>, Andrew Peace <Andrew.Peace@xxxxxxxxxxxxx>
Delivery-date: Thu, 17 Dec 2009 08:00:00 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B2A21D902000078000266D3@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acp/CtIRPGf0GDXMSlmIC+77CWg4fAAJxiO6
Thread-topic: [Xen-devel] [PATCH] Paging and memory sharing for HVM guests
User-agent: Microsoft-Entourage/
On 17/12/2009 11:19, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>> The series of 46 patches attached to this email contain the initial
>> implementation of memory paging and sharing for Xen. Patrick Colp
>> leads the work on the pager, and I am mostly responsible for memory
>> sharing. We would be grateful for any comments/suggestions you might
>> have. Individual patches are labeled with comments describing their
>> purpose and a sign-off footnote. Of course we are happy to discuss
>> them in more detail, as required. Assuming that there are no major
>> objections against including them in the mainstream xen-unstable tree,
>> we would like to move future development to that tree.
> as I just realized you already committed these patches - wouldn't it
> make sense to allow for some reviewing/discussion at least for larger
> batches like this? I would really have wanted the Linux side issues I
> already pointed out fixed before they go in, and lacking a general
> description of the approach taken I didn't even take a closer look at
> the Xen side changes (but during the brief check I did, I think I
> spotted at least one problem already).

Well, maybe I jumped the gun a bit. But I think this feature is inevitable
-- everyone wants it -- so it's a choice between fixing up in tree versus
out of tree. Perhaps it would have been better to get at least the first
round of fixes done before check in.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>