 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] libxl: build fix
| To: | Christoph Egger <Christoph.Egger@xxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] libxl: build fix |
| From: | Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> |
| Date: | Fri, 4 Dec 2009 15:52:37 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Fri, 04 Dec 2009 07:53:02 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <200912011540.35879.Christoph.Egger@xxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Newsgroups: | chiark.mail.xen.devel |
| References: | <200912011540.35879.Christoph.Egger@xxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Christoph Egger writes ("[Xen-devel] [PATCH] libxl: build fix"):
> Attached patch makes libxl build on NetBSD.
The patch is fine, although I don't generally approve of comments like
the one you've included:
+#include <signal.h> /* for SIGKILL */
I would just say:
+#include <signal.h>
and you can mention SIGKILL in the commit message.
There is an argument that all of these headers should be included in
one place by libxl_internal.h.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Prepping a bugfix push, Ian Campbell |
|---|---|
| Next by Date: | [Xen-devel] [GIT] domain 0 build fix, Ian Campbell |
| Previous by Thread: | [Xen-devel] [PATCH] libxl: build fix, Christoph Egger |
| Next by Thread: | Re: [Xen-devel] [PATCH 0 of 3] Remus: control tool, Pasi Kärkkäinen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
