This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] libxenlight: fix multiple xenstore watches probl

To: Vincent Hanquez <Vincent.Hanquez@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxenlight: fix multiple xenstore watches problem
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Thu, 3 Dec 2009 15:39:57 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 03 Dec 2009 07:36:30 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20091203154117.GB16654@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.0912021455450.26846@kaball-desktop> <20091203154117.GB16654@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Thu, 3 Dec 2009, Vincent Hanquez wrote:
> On Wed, Dec 02, 2009 at 03:01:32PM +0000, Stefano Stabellini wrote:
> > Hi all,
> > this patch fixes the multiple xenstore watches problem in libxenlight
> > opening a new xenstore connection to set and read temporary watches on
> > the device state nodes.
> > This way they don't interfere with other long running watches.
> This thing doesn't make sense; you're solving the wrong problem with cloning
> the context. you can open a cheap xenstore connection for temporary watches 
> and
> be done with it.

You are right about that, but Andres found the bug and fixed it with his
"clone context to avoid GC corruption" patch.
We can limit the memory allocated for the new alloc_ptrs to something
much smaller than 256 in libxl_clone_context if you are worried about
memory allocation.

Xen-devel mailing list