This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 0 of 3] Remus: control tool

To: pasik@xxxxxx, konrad.wilk@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, andy@xxxxxxxxx
Subject: Re: [Xen-devel] [PATCH 0 of 3] Remus: control tool
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Tue, 01 Dec 2009 15:04:49 -0800
Delivery-date: Tue, 01 Dec 2009 15:05:13 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20091201161619.GA2438@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1258074621@xxxxxxxxxxxx> <20091113141859.GB23952@xxxxxxxxxxxxxxxxxxx> <20091113213627.GD11642@xxxxxxxxxxxxxxxxx> <20091201152012.GY16033@xxxxxxxxxxx> <20091201161619.GA2438@xxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Thunderbird/3.0b4
On 12/01/09 08:16, Brendan Cully wrote:
> I'll probably take a crack at this soon. From a quick look at the
> pvops suspend code, it seems like it may suffer from a race when
> multiple suspends are issued that Keir fixed in the 2.6.18 tree some
> time ago -- it'd be better to get that fixed before porting the event
> channel patch.

What's the bug?  I don't see a reentrancy issue there because the
suspend happens synchronously in the xenwatch thread under
xenwatch_mutex.  Or race for that matter.

Am I missing something?

Of course, if you start triggering suspends via event channels, we'll
need to work out something else.


Xen-devel mailing list