 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] libxc: failure to save/restore 32bit HVM guest
| To: | Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] libxc: failure to save/restore 32bit HVM guest |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Tue, 24 Nov 2009 19:58:48 +0000 |
| Cc: | "Xen-devel@xxxxxxxxxxxxxxxxxxx" <Xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Tue, 24 Nov 2009 11:59:32 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20091124112348.7542f11d@xxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcptO+V+rSB8nJ+AQ+qr2/eAIVTRMwABKOp1 |
| Thread-topic: | [Xen-devel] [PATCH] libxc: failure to save/restore 32bit HVM guest |
| User-agent: | Microsoft-Entourage/12.23.0.091001 |
On 24/11/2009 19:23, "Mukesh Rathor" <mukesh.rathor@xxxxxxxxxx> wrote:
> Anyways, since 32bit HVM returns 64bit contexts, it appears the way it
> is, is buggy, since the sizeof(ctxt[0].c) will return 32bit context
> size in 32 bit libxc. Infact, after making the fix, user is able to get
> proper core of a Java HVM guest. Can you please quickly explain why you
> think it's correct in such case?
Ah, maybe you are right after all. But shouldn't you change the last two
arguments in the call:
sts = xc_core_shdr_set(shdr, strtab, XEN_DUMPCORE_SEC_PRSTATUS,
SHT_PROGBITS, offset, filesz,
__alignof__(ctxt[0].c), sizeof(ctxt[0].c));
...to reference *ctxt instead of ctxt[0].c, as well?
If you agree, send an updated patch and I'll apply it.
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Bug when disabling/enabling a PT device with MSI enabled, Konrad Rzeszutek Wilk |
|---|---|
| Next by Date: | Re: [Xen-devel] Question: dom0 electrocuted by implicitly unmapped grantrefs, Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] [PATCH] libxc: failure to save/restore 32bit HVM guest, Mukesh Rathor |
| Next by Thread: | Re: [Xen-devel] [PATCH] libxc: failure to save/restore 32bit HVM guest, Mukesh Rathor |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
