This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] libxc: failure to save/restore 32bit HVM guest

To: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>, "Xen-devel@xxxxxxxxxxxxxxxxxxx" <Xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxc: failure to save/restore 32bit HVM guest
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 24 Nov 2009 08:48:16 +0000
Delivery-date: Tue, 24 Nov 2009 00:48:44 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20091123151406.36e032c8@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acpskr6xRH4inLuAS+msfTXysr864AAUB5Wc
Thread-topic: [Xen-devel] [PATCH] libxc: failure to save/restore 32bit HVM guest
User-agent: Microsoft-Entourage/
On 23/11/2009 23:14, "Mukesh Rathor" <mukesh.rathor@xxxxxxxxxx> wrote:

> Following appears to be an obvious bug. Save/restore of HVM guests
> works fine after the following fix. Including the patch, please let me
> know if you agree. I'll make parallel fix in our previous versions
> here.

Save/restore of HVM guests should work fine before this fix too, since
nothing in xc_core.c is used for guest save/restore. It's used for core
dumps, as the name implies, and which is a rather different thing.

Furthermore I think the code in xc_core.c is correct as is.

 -- Keir

Xen-devel mailing list