This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Relax assertion in VRAM tracking code

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Relax assertion in VRAM tracking code
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Mon, 23 Nov 2009 11:39:24 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 23 Nov 2009 03:39:51 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B0A7F81020000780002162A@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20091116170040.GC14284@xxxxxxxxxxxxxxxxxxxxxxx> <4B0A7F81020000780002162A@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
At 11:26 +0000 on 23 Nov (1258975601), Jan Beulich wrote:
> >>> Tim Deegan <Tim.Deegan@xxxxxxxxxx> 16.11.09 18:00 >>>
> >The original assertion is too strict, as it includes the A/D bits of the 
> >PTE, which (by design) can change under our feet.
> >
> >Signed-off-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
> Wouldn't the comparison a few lines down from the ASSERT() thus fixed
> also benefit from a similar adjustment?

Actually, on closer inspection my original fix was wrong; the bottom 12
bits of sl1ma are taken from the _pointer_ to the sl1e, not the
contents, so the assertion is plausible.

Keir, can you please revert it?


Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Citrix Systems (R&D) Ltd.
[Company #02300071, SL9 0DZ, UK.]

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>