Re: [Xen-devel] [PATCH 0/7][RFC] make xenguest save & restore functions reentrant

[Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>]

Keir Fraser wrote:
> Another option would be for all users of the macros to have a 'xenguest_ctx'
> structure, or whatever you call it. So e.g., in xc_resume:
>  struct xenguest_ctx _ctx, *ctx = &_ctx;
>  ctx->guest_width = ...
>  /* Leave unnecessary/meaningless fields for this caller uninitialised. */
>
> What do you think? The ctx struct can't be that big; we can just ignore
> fields that make no sense outside save/restore (i.e., kind of split it into
> general-purpose and private/application-specific fields); and it does keep
> the macro invocations cleaner.
I'll give that a try. I don't think it's going to make that serie much 
nicer though.
--
Vincent

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel