This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 0/7][RFC] make xenguest save & restore functions

To: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/7][RFC] make xenguest save & restore functions reentrant
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Sat, 14 Nov 2009 08:25:05 +0000
Delivery-date: Sat, 14 Nov 2009 00:25:31 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1258155787-28327-1-git-send-email-vincent.hanquez@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcpkumFKBGjzIX7KQuaHGw+0lFyHSwASZaAK
Thread-topic: [Xen-devel] [PATCH 0/7][RFC] make xenguest save & restore functions reentrant
User-agent: Microsoft-Entourage/
On 13/11/2009 23:43, "Vincent Hanquez" <vincent.hanquez@xxxxxxxxxxxxx>

> The following patchset make suspend and restore code reentrant by having an
> explicit context to store current variables across all the suspend/restore
> code.
> This work is necessary for beeing able to get rid of the fork of processes
> during save&restore, and provide a simpler interface for toolstack developers.

Rather than making the macros take extra arguments, can you make them refer
to ctx->foo instead (i.e., make it implciit the structure containing these
ex-globals is called ctx)? It avoids having to change every caller, and some
callers already have macros nested three deep and adding guest_width/max_mfn
all over the place does not help readability.

Also send also as attachments next time. I have problems applying these
patches from inline email for some reason; some chunks don't apply.

 -- Keir

Xen-devel mailing list