WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][RFC] pv-ops: fix shared irq device passthrough

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][RFC] pv-ops: fix shared irq device passthrough
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Tue, 10 Nov 2009 10:44:59 -0800
Cc: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>, "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Han, Weidong" <weidong.han@xxxxxxxxx>, "'keir.fraser@xxxxxxxxxxxxx'" <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Tue, 10 Nov 2009 10:46:03 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20091110163058.GB23000@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <715D42877B251141A38726ABF5CABF2C05509A75F3@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4AE60646.7050307@xxxxxxxx> <715D42877B251141A38726ABF5CABF2C05509A7C3A@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4AEA1D82.8060609@xxxxxxxx> <715D42877B251141A38726ABF5CABF2C0550A02DAD@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4AEB5BF9.20307@xxxxxxxx> <715D42877B251141A38726ABF5CABF2C055064A406@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <715D42877B251141A38726ABF5CABF2C0550A64B6C@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <715D42877B251141A38726ABF5CABF2C05534DC58B@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20091110163058.GB23000@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4
On 11/10/09 08:30, Konrad Rzeszutek Wilk wrote:
> With this patch you can share the PCI devices on the same IRQ, correct? Will
> this mean that you can assign to a guest a USB controller, while
> Dom0 has controller of the PCI NIC (and assuming that both of those
> share the same interrupt line)? If so, won't the Dom0 start throwing
> a fit b/c there are unhandled IRQs and eventually disable the IRQ line?
>
>
> Or even the guest decide that there are too many IRQs and decided to
> disable the IRQ line?
>   

It would be easy to add a dummy handler which always returns IRQ_HANDLED
for every cross-domain shared interrupt to prevent this.  Of course that
would paper over any real spurious/screaming interrupt problem, but we
could add some extra logic into the dummy handler if necessary.

I merged the patch, and had to add the new parameter to
xen_allocate_pirq() in arch/x86/pci/xen.c.  I just made it 0 which
should have no functional difference from before, but I'll leave it to
you to decide what it really should be.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel