This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: [PATCH] to fix the bug for tboot on x86_32 brought by c/

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Cihula, Joseph" <joseph.cihula@xxxxxxxxx>, "Hao, Xudong" <xudong.hao@xxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH] to fix the bug for tboot on x86_32 brought by c/s 19914 and 19922
From: "Wang, Shane" <shane.wang@xxxxxxxxx>
Date: Mon, 9 Nov 2009 10:55:56 +0800
Accept-language: en-US
Acceptlanguage: en-US
Delivery-date: Sun, 08 Nov 2009 18:56:53 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C719FD3A.19675%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4AF408A1.9060600@xxxxxxxxx> <C719FD3A.19675%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acpe1G/Uc8K6RsddTFuL30OEdNr1hgAKJL3vAHqtYyA=
Thread-topic: [PATCH] to fix the bug for tboot on x86_32 brought by c/s 19914 and 19922
Keir Fraser wrote:
> On 06/11/2009 11:29, "Shane Wang" <shane.wang@xxxxxxxxx> wrote:
>> The changesets 19914 and 19922 remove the bitmap for boot allocator,
>> which causes first_valid_mfn is reduced and starts from the end of
>> xen. On the other hand, on x86_64, the xen heap is got considering
>> e820 table, while on x86_32 the xen heap is specified to be <
>> xenheap_phys_end. This range overlaps tboot range. So, the tboot
>> range is scrubbed by scrub_heap_pages() during start_xen() on
>> x86_32. Then the result is that for TXT support on x86_32,
>> shutdown/reboot/Sx doesn't work properly. (i.e. hang) 
> So... The problem is that xenheap on x86_32 does not respect e820?
> I'll fix that if that's the issue. It will be a much smaller change,
> and to arch/x86/setup.c only.
Yes, it is. It seems x86_32 only respects after xenheap is created.

>  -- Keir
>> This patch is to fix that by reserving tboot range as "inuse" in xen
>> heap on x86_32. Then xen code will not touch the range.

Xen-devel mailing list