This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] to fix the bug for tboot on x86_32 brought by c/

To: Shane Wang <shane.wang@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Cihula, Joseph" <joseph.cihula@xxxxxxxxx>, "xudong.hao@xxxxxxxxx" <xudong.hao@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] to fix the bug for tboot on x86_32 brought by c/s 19914 and 19922
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 06 Nov 2009 16:20:10 +0000
Delivery-date: Fri, 06 Nov 2009 08:21:34 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4AF408A1.9060600@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acpe1G/Uc8K6RsddTFuL30OEdNr1hgAKJL3v
Thread-topic: [PATCH] to fix the bug for tboot on x86_32 brought by c/s 19914 and 19922
User-agent: Microsoft-Entourage/
On 06/11/2009 11:29, "Shane Wang" <shane.wang@xxxxxxxxx> wrote:

> The changesets 19914 and 19922 remove the bitmap for boot allocator, which
> causes first_valid_mfn is reduced and starts from the end of xen. On the other
> hand, on x86_64, the xen heap is got considering e820 table, while on x86_32
> the xen heap is specified to be < xenheap_phys_end. This range overlaps tboot
> range.
> So, the tboot range is scrubbed by scrub_heap_pages() during start_xen() on
> x86_32. Then the result is that for TXT support on x86_32, shutdown/reboot/Sx
> doesn't work properly. (i.e. hang)

So... The problem is that xenheap on x86_32 does not respect e820? I'll fix
that if that's the issue. It will be a much smaller change, and to
arch/x86/setup.c only.

 -- Keir

> This patch is to fix that by reserving tboot range as "inuse" in xen heap on
> x86_32. Then xen code will not touch the range.

Xen-devel mailing list