This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-API] RE: [Xen-devel] [PATCH] xapi toolstack (xen-api-libs): fix com

To: 'Andreas Florath' <xen@xxxxxxxxxxxx>, Thomas Gazagnaire <Thomas.Gazagnaire@xxxxxxxxxxxxx>
Subject: [Xen-API] RE: [Xen-devel] [PATCH] xapi toolstack (xen-api-libs): fix compile errors
From: Dave Scott <Dave.Scott@xxxxxxxxxxxxx>
Date: Fri, 6 Nov 2009 17:16:16 +0000
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "xen-api@xxxxxxxxxxxxxxxxxxx" <xen-api@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 06 Nov 2009 09:16:21 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20091106173351.bhcovy5gcg04s4gk@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-api-request@lists.xensource.com?subject=help>
List-id: Discussion of API issues surrounding Xen <xen-api.lists.xensource.com>
List-post: <mailto:xen-api@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=unsubscribe>
References: <20091106135109.yns1w2khdwkk800g@xxxxxxxxxxxxxxxxxxxx> <DECC4DEE86A8074C9ABE8DFD330CB6E341A191D9A1@xxxxxxxxxxxxxxxxxxxxxxxxx> <20091106173351.bhcovy5gcg04s4gk@xxxxxxxxxxxxxxxxxxxx>
Sender: xen-api-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acpe/vWP3pgMU7xKTsOuanOgoKU0NAAAzWHg
Thread-topic: [Xen-devel] [PATCH] xapi toolstack (xen-api-libs): fix compile errors
Andreas wrote:
> Does this mean, that the xen-api toolchain does not work (compile)  
> with xen-unstable or some currently released Xen?  Does it only  
> compile with some Citrix internal available source?

It only currently compiles with this xen patchqueue applied:

(applied to the tag RELEASE-3.4.1 in xen-3.4-testing.hg)

We haven't done any recent testing against xen-unstable... but we probably 
should! Perhaps we could fix this XS_RESTRICT problem with some #ifdef magic 
for the time-being. 

We're keen to get rid of these patchqueues but it will take some time.

> But I'm not sure if this is the best place for comments. IMHO when  
> somebody changes the xb.ml file, the xb.mli file will be overwritten;  
> see Makefile:
> %.mli: %.ml
>         $(OCAMLC) -i $< > $@

Oops :) 
We've been trying to add ocamldoc comments to .mli files which we can use to 
generate stuff like: 

I think we should zap this Makefile rule and keep our comments. 

> Then 'make allxen' prints:
> File "xb.ml", line 1, characters 0-1:
> Error: The files op.cmi and xb.cmi make inconsistent assumptions
>        over interface Op
> A 'touch xb/xb.mli && make allxen' works.
> IMHO this is because of missing dependencies in the Makefile. Try to  
> add one additional operation in op.ml and type 'make'. You'll see a  
> similar error. It looks that dependency tracking is missing:
> Example: xb.ml uses op.ml but it is not rebuild when op.ml changes.

I'm sure you're right. We've been a bit lazy with our dependencies in this 
repo, falling back to 'make clean && make'. Things are better in xen-api.hg 
where 'omake' (like 'make' but with a bit more ocaml-awareness) is quite good 
at tracking dependencies itself.

xen-api mailing list