This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-API] RE: [Xen-devel] [PATCH] xapi toolstack (xen-api-libs): fix com

To: 'Andreas Florath' <xen@xxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-API] RE: [Xen-devel] [PATCH] xapi toolstack (xen-api-libs): fix compile errors
From: Thomas Gazagnaire <Thomas.Gazagnaire@xxxxxxxxxxxxx>
Date: Fri, 6 Nov 2009 15:09:17 +0000
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-api@xxxxxxxxxxxxxxxxxxx" <xen-api@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 06 Nov 2009 07:09:21 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20091106135109.yns1w2khdwkk800g@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-api-request@lists.xensource.com?subject=help>
List-id: Discussion of API issues surrounding Xen <xen-api.lists.xensource.com>
List-post: <mailto:xen-api@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=unsubscribe>
References: <20091106135109.yns1w2khdwkk800g@xxxxxxxxxxxxxxxxxxxx>
Sender: xen-api-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acpe39xEVS0TLjuoT22pn1JOwO8EYAAAg/Sw
Thread-topic: [Xen-devel] [PATCH] xapi toolstack (xen-api-libs): fix compile errors
Hi Andreas,

XS_RESTRICT is defined in this Xen patch-queue:

Basically, it is used by xapi/oxenstored to drop the xenstore permissions of 
qemu inside dom0. This gives to qemu processes the same permissions than their 
associated domU concerning read/write of xenstore nodes. It is quite useful to 
avoid any security issue with qemu backends.

Because of that, your patch will broke the starting of HVM domains for XCP. I 
believe the best fix for this is to upstream our Xen patch-queue :-) and in a 
more practical way, I believe we should do something like:
1. Add a #define XS_RESTRICT in 
2. In xen-api-libs.hg/xb/xb_stubs.c, test if XS_RESTRICT is defined. If yes, 
use the value if XS_RESTRICT, else use a default value (128, as defined in the 
patch queue, for example).

About xb.mli file: it is supposed to be the exposed interface, which contains 
some bits of documentation, so it cannot be auto-generated. Thus, it would be 
better to not remove it.


> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx [mailto:xen-devel-
> bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Andreas Florath
> Sent: Friday, November 06, 2009 12:51 PM
> To: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: [Xen-devel] [PATCH] xapi toolstack (xen-api-libs): fix compile
> errors
> Hello!
> There are two compile errors when 'make allxen' in xen-api-libs.
> o XS_RESTRICT is not defined (c compiler error) o xb.mli file was checked
> in (ocaml error)
> The attached patch should remove those problems.
> Kind regards - Andreas

xen-api mailing list