WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86/dom0: support bzip2 and lzma compressed bzIm

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86/dom0: support bzip2 and lzma compressed bzImage payloads
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Fri, 6 Nov 2009 09:11:55 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 06 Nov 2009 01:12:22 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4AF3F44A020000780001E03A@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <4AF2EE46020000780001DCDF@xxxxxxxxxxxxxxxxxx> <1257497801.23110.3795.camel@xxxxxxxxxxxxxxxxxxxxxx> <4AF3F44A020000780001E03A@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2009-11-06 at 09:02 +0000, Jan Beulich wrote:
> >>> Ian Campbell <Ian.Campbell@xxxxxxxxxx> 06.11.09 09:56 >>>
> >On Thu, 2009-11-05 at 14:24 +0000, Jan Beulich wrote:

> >the next person to come along who wants to resync them. (and why rename
> >them?)
> 
> The decompress_* prefix seemed pointless to me.

I guess it just highlights all those files as being part of the same
"subsystem".

> >> The question is whether, particularly for non-Linux Dom0-s, plain ELF
> >> images compressed by bzip2 or lzma should also be supported.
> >
> >It should be fairly low cost to do so, so why not?
> >
> >Is there a reason to treat gzip differently to bzip2/lzma? i.e. why not
> >route it through decompress.c as well? Perhaps that would involve
> >updating xen/common/inflate.c but that is already just a fork of what is
> >now in lib/decompress_inflate.c in Linux so it should be pretty trivial.
> 
> Yes, I had considered that, but didn't want the patch to become bigger
> than necessary. I'm certainly planning on cleaning this up as a subsequent
> (though lower priority) patch.

Great, thanks!

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>