This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] x86/dom0: support bzip2 and lzma compressed bzIm

To: "Ian Campbell" <Ian.Campbell@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86/dom0: support bzip2 and lzma compressed bzImage payloads
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Fri, 06 Nov 2009 09:02:50 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 06 Nov 2009 01:03:17 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1257497801.23110.3795.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4AF2EE46020000780001DCDF@xxxxxxxxxxxxxxxxxx> <1257497801.23110.3795.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Ian Campbell <Ian.Campbell@xxxxxxxxxx> 06.11.09 09:56 >>>
>On Thu, 2009-11-05 at 14:24 +0000, Jan Beulich wrote:
>> This matches functionality in the tools already supporting the same for
>> DomU-s.
>> Code taken from Linux 2.6.32-rc and adjusted as little as possible to
>> be usable in Xen.
>Looks good to me. The new files FOO.c are based on lib/decompress_FOO.c
>from Linux? Might be worth a comment in at least the changelog to aid


>the next person to come along who wants to resync them. (and why rename

The decompress_* prefix seemed pointless to me.

>> The question is whether, particularly for non-Linux Dom0-s, plain ELF
>> images compressed by bzip2 or lzma should also be supported.
>It should be fairly low cost to do so, so why not?
>Is there a reason to treat gzip differently to bzip2/lzma? i.e. why not
>route it through decompress.c as well? Perhaps that would involve
>updating xen/common/inflate.c but that is already just a fork of what is
>now in lib/decompress_inflate.c in Linux so it should be pretty trivial.

Yes, I had considered that, but didn't want the patch to become bigger
than necessary. I'm certainly planning on cleaning this up as a subsequent
(though lower priority) patch.


Xen-devel mailing list