WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH v2] Allow guests to register secondary vcpu_time_

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [PATCH v2] Allow guests to register secondary vcpu_time_info
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 20 Oct 2009 08:31:24 +0100
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 20 Oct 2009 00:32:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4ADCFAFE.3020202@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcpRFsk+CklGRSw2Rz+KaO7dx19l2gAQIpZm
Thread-topic: [PATCH v2] Allow guests to register secondary vcpu_time_info
User-agent: Microsoft-Entourage/12.20.0.090605
On 20/10/2009 00:49, "Jeremy Fitzhardinge" <jeremy@xxxxxxxx> wrote:

> On 10/20/09 07:16, Jeremy Fitzhardinge wrote:
>> Looks OK.  One thing: if it's using __copy_to_guest, should it first
>> test the handle with guest_handle_okay()?
>>   
> 
> Oh, I see it happens at the hypercall.  I guess the results of the test
> can't be invalidated.

Indeed. Also your original patch used __copy_to_guest.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel