WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH v2] Allow guests to register secondary vcpu_time_

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH v2] Allow guests to register secondary vcpu_time_info
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Tue, 20 Oct 2009 07:16:59 +0900
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 19 Oct 2009 15:17:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C70205CB.17E32%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C70205CB.17E32%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4
On 10/19/09 20:02, Keir Fraser wrote:
> On 16/10/2009 15:34, "Jeremy Fitzhardinge" <jeremy@xxxxxxxx> wrote:
>
>   
>> On 10/12/09 14:08, Keir Fraser wrote:
>>     
>>> You'll send me a simplified version of this that doesn't need to support
>>> guest update of the version field, right?
>>>   
>>>       
>> Here's the simplified version.  But I'm wondering if it should do the
>> proper version update with write barriers to make it the same as the
>> normal vcpu_time_info update protocol.
>>     
> I fixed this and applied as c/s 20339. Take a look.
>   

Looks OK.  One thing: if it's using __copy_to_guest, should it first
test the handle with guest_handle_okay()?

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel