This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH] fix ioemu build

To: Christian Tramnitz <chris.ace@xxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] fix ioemu build
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Mon, 10 Aug 2009 16:06:34 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 10 Aug 2009 08:06:57 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A7B5CE0.8080907@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <4A7B5366.7000400@xxxxxxx> <C6A11819.1191C%keir.fraser@xxxxxxxxxxxxx> <4A7B5CE0.8080907@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Christian Tramnitz writes ("[Xen-devel] Re: [PATCH] fix ioemu build"):
> Keir Fraser wrote:
> > But... 'rm -f' doesn't fail when the file doesn't exist?
> It doesn't, but under circumstances this is escaping the sandbox and 
> generating an access violation.

Err, what ?  What sandbox ?  Some kind of special Gentoo build
environment ?

> Details are available here:
> http://bugs.gentoo.org/262124

This shows this error message:
 ACCESS DENIED  unlinkat:     /Makefile

That appears to suggest that it's trying to delete /Makefile, rather
than some more sensible path.  Is that really what's going on ?  In
which case the problem is that it's accessing the wrong paths, not
that rm -f isn't working.  Perhaps some source directory variable
isn't being set properly ?

I suggest you investigate in that direction.  If you get stuck let me
know and I'll take a look myself.

> Not really sure if this only manifests itself in the gentoo build 
> environment, but since other places in xen-setup check for the existence 
> of the file before doing sth with it, I don't think it would hurt to apply.

The patch is definitely wrong.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>