This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] fix ioemu build

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [PATCH] fix ioemu build
From: Christian Tramnitz <chris.ace@xxxxxxx>
Date: Fri, 07 Aug 2009 00:44:48 +0200
Delivery-date: Thu, 06 Aug 2009 15:45:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C6A11819.1191C%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4A7B5366.7000400@xxxxxxx> <C6A11819.1191C%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (Windows/20090605)
Keir Fraser wrote:
Anyway checking for the existence of a file before actually deleting it
shouldn't really hurt...

But... 'rm -f' doesn't fail when the file doesn't exist?

It doesn't, but under circumstances this is escaping the sandbox and generating an access violation. This was initially reported for 3.3.1 as gentoo bug and fixed with this patch. Now I'm trying to get the live ebuilds working but patching is not an option there...

Details are available here:

Not really sure if this only manifests itself in the gentoo build environment, but since other places in xen-setup check for the existence of the file before doing sth with it, I don't think it would hurt to apply.

Btw, the path in my patch was wrong, I guess it should be qemu-xen-unstable instead of ioemu-dir.

Best regards,

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>