WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [ANNOUNCE] Xen 3.3.2 and 3.4.1 released

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [ANNOUNCE] Xen 3.3.2 and 3.4.1 released
From: Andrew Lyon <andrew.lyon@xxxxxxxxx>
Date: Mon, 10 Aug 2009 13:46:30 +0100
Cc: KUWAMURA Shin'ya <kuwa@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Mon, 10 Aug 2009 05:47:33 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=dRtc+kvSw33UPnC8tKvFOaJ4+1Ga5n7F3ep5X5JKZtA=; b=kBIlGRICwtxxT6zodYii+s17UhTCuU5fPJRtzXKQ38Hsvu6Pp3499T0ob+le10Xm4l u6nRcM2YGEXXFrm0eSeFAxO1mCQy5LufsOaUujxAaP2VBLvkehYFn2SBpK7PiQZj+s7h 2/dqos8mSDWeqLXOZLQ0xj9vnx21kq9s6Man8=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=r6BgvvGMa8EObye7edXJPvTtZjEHwffdrT7WsnBj9/kv9ByuwPRMPV3qskx1I775qQ uq9MyjUw5HMS8fpehhbksP31EIUNWbHDAot8jAyiq+cGGqikdEudLe5DAmrG0h87IHBw 1y3wtKZyu0QlQWftQzYkancHGRx9TpR58Kwbs=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19072.994.344657.139865@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <f4527be0908100311g1151b6bcsfc25a2592dd7a46e@xxxxxxxxxxxxxx> <C6A5BC93.11C0A%keir.fraser@xxxxxxxxxxxxx> <19072.994.344657.139865@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, Aug 10, 2009 at 12:26 PM, Ian Jackson<Ian.Jackson@xxxxxxxxxxxxx> wrote:
> On 10/08/2009 11:11, "Andrew Lyon" <andrew.lyon@xxxxxxxxx> wrote:
>> Sorry to report this on the final 3.4.1 but I never had time to test
>> any of the rc's, it appears that the fix for using videoram config
>> setting was not applied to 3.4.1, when I try to start a domain with
>> stdvga=1 and videoram=16 it fails:
>
> Do you mean this:
>
>  commit e0bb6b8df60863bca0163a1688baf4854e931e55
>  Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
>  Date:   Mon Jun 8 17:45:42 2009 +0100
>
>      stdvga + videoram config option
>
>      Without this patch, guests cannot be created on ia64 because of
>      qemu-dm's error.
>
>      Signed-off-by: KUWAMURA Shin'ya <kuwa@xxxxxxxxxxxxxx>
>
> That appears to remove this assignment
>      ram_size = vga_ram_size;
> from an ia64-specific fragment in vl.c which doesn't appear in the 3.4
> branch.
>
> If that's not what you meant, what did you mean ? :-)
>
> Ian.
>

Yes that is the correct pair of patches, I have tested on x86_64 and I
am able to create hvm with increased video ram, I do not see much
value in applying a patch which does not work and then fixing it if
both are not currently in 3.4 so here is a single patch instead,
perhaps KUWAMURA Shin'ya can add a signed-off-by to this too.

Signed-off-by: Andrew Lyon <andrew.lyon@xxxxxxxxx>


---

diff --git tools/ioemu-qemu-xen/vl.c tools/ioemu-qemu-xen/vl.c
index b5bb5cb..3506977 100644
--- tools/ioemu-qemu-xen/vl.c
+++ tools/ioemu-qemu-xen/vl.c
@@ -4801,7 +4801,6 @@ int main(int argc, char **argv, char **envp)
     machine = first_machine;
     cpu_model = NULL;
     initrd_filename = NULL;
-    ram_size = VGA_RAM_SIZE;
 #ifdef CONFIG_GDBSTUB
     use_gdbstub = 0;
     gdbstub_port = DEFAULT_GDBSTUB_PORT;
@@ -5654,13 +5653,6 @@ int main(int argc, char **argv, char **envp)
     }
 #endif

-#if defined (__ia64__)
-    if (ram_size > VGA_IO_START)
-        ram_size += VGA_IO_SIZE; /* skip VGA I/O hole */
-    if (ram_size > MMIO_START)
-        ram_size += 1 * MEM_G; /* skip 3G-4G MMIO, LEGACY_IO_SPACE etc. */
-#endif
-
     /* init the bluetooth world */
     for (i = 0; i < nb_bt_opts; i++)
         if (bt_parse(bt_opts[i]))
@@ -5677,6 +5669,13 @@ int main(int argc, char **argv, char **envp)

     phys_ram_size = (machine->ram_require + vga_ram_size) & ~RAMSIZE_FIXED;

+#if defined (__ia64__)
+    if (ram_size > VGA_IO_START)
+        ram_size += VGA_IO_SIZE; /* skip VGA I/O hole */
+    if (ram_size > MMIO_START)
+        ram_size += 1 * MEM_G; /* skip 3G-4G MMIO, LEGACY_IO_SPACE etc. */
+#endif
+
     if (machine->ram_require & RAMSIZE_FIXED) {
         if (ram_size > 0) {
             if (ram_size < phys_ram_size) {


Andy

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel