This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: compat tool problem with new tmem save/restore tmem_op s

To: "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx>
Subject: [Xen-devel] Re: compat tool problem with new tmem save/restore tmem_op struct
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Wed, 29 Jul 2009 07:54:14 +0100
Cc: "Xen-Devel \(E-mail\)" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 28 Jul 2009 23:53:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <51535100-ad71-40cc-83fe-f09b7bb62c5c@default>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <51535100-ad71-40cc-83fe-f09b7bb62c5c@default>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> 28.07.09 20:00 >>>
>I'm trying to implement save/restore code for tmem
>and to do so I need to pass other variants of the
>tmem_op struct between tools (dom0) and the hypervisor
>so I made the changes below to struct tmem_op.
>Unfortunately the nested union seems to break your compat
>translation tool.  Is this an easy fix for your
>tool?  If not, I suppose I can recode to only
>use a single level of union.

Would be good if you pointed out *how* it fails - it doesn't look as if it
should have a problem with such a layout (and hence if it does I'd think
it should be fixed). I'll try it out myself once I can get to it, but it's 
that this would be earlier than next week.

And (after having read you follow up mail) I'd think flattening the structure
isn't the right thing to do.


Xen-devel mailing list