This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: compat tool problem with new tmem save/restore tmem_op s

To: dan.magenheimer@xxxxxxxxxx, Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: [Xen-devel] RE: compat tool problem with new tmem save/restore tmem_op struct
From: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
Date: Tue, 28 Jul 2009 14:11:12 -0700 (PDT)
Cc: "Xen-Devel \(E-mail\)" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 28 Jul 2009 14:11:55 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <51535100-ad71-40cc-83fe-f09b7bb62c5c@default>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> Hi Jan --
> I'm trying to implement save/restore code for tmem
> and to do so I need to pass other variants of the
> tmem_op struct between tools (dom0) and the hypervisor
> so I made the changes below to struct tmem_op.
> Unfortunately the nested union seems to break your compat
> translation tool.  Is this an easy fix for your
> tool?  If not, I suppose I can recode to only
> use a single level of union.

FYI, I've converted the code to a single level union,
but the result is questionable as the subop that
selects which structure in the union is the first
element of each structure.  This also required some
messy work in the CONFIG_COMPAT in tmh_get_tmemop_from_client,
but it compiles now and I can proceed with debugging.


Xen-devel mailing list