This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] tools: use C99 __VA_ARGS__

On Tuesday 21 July 2009 15:50:56 Ian Jackson wrote:
> Christoph Egger writes ("Re: [Xen-devel] [PATCH] tools: use C99 
> > On Tuesday 21 July 2009 15:26:14 Ian Jackson wrote:
> > > Christoph Egger writes ("[Xen-devel] [PATCH] tools: use C99 
> > > > Attached patch switches tools to consistently use C99 __VA_ARGS__.
> > >
> > > What is the benefit of this ?
> >
> > Consistency in the whole tree in combination with two other patches
> > (xen-kernel and minios) which I have not yet submitted.
> Umm, so what's the benefit of the whole patchset ?

Consistency. :)

> > > Xen requires GCC and the GCC variable
> > > argument list extension has been around forever,
> >
> > That's not a reason to stick on old things.
> Neither is there apparently any reason to change.
> > > so it doesn't seem to aid portability.
> >
> > No, not in this case.
> >
> > But the other patch for the xen-kernel touches
> > the public headers.
> > AFAIK the public headers should follow the standard.
> Do the public headers currently work with other compilers ? 

Yes, Sun compiler.

> There is an argument for using the standard syntax there to make it easier
> for kernels compiled with non-GCC compilers to provide Xen guest support.

I have attached the part of the xen-kernel patch which touches the public 
headers only. I suppose, Sun didn't use acm or they would have noticed it.

Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>


---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Attachment: xen_public_varargs.diff
Description: Text Data

Xen-devel mailing list