This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] tools: use C99 __VA_ARGS__

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] tools: use C99 __VA_ARGS__
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Tue, 21 Jul 2009 15:47:20 +0200
Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Tue, 21 Jul 2009 06:47:59 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19045.49654.819861.134478@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200907211501.15045.Christoph.Egger@xxxxxxx> <19045.49654.819861.134478@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.7
On Tuesday 21 July 2009 15:26:14 Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] tools: use C99 __VA_ARGS__"):
> > Attached patch switches tools to consistently use C99 __VA_ARGS__.
> What is the benefit of this ?

Consistency in the whole tree in combination with two other patches
(xen-kernel and minios) which I have not yet submitted.

> Xen requires GCC and the GCC variable 
> argument list extension has been around forever,

That's not a reason to stick on old things.

> so it doesn't seem to aid portability.

No, not in this case.

But the other patch for the xen-kernel touches
the public headers.
AFAIK the public headers should follow the standard.

> The GCC syntax is considerably prettier than the C99 one.

This is subjective.


---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Xen-devel mailing list