WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH]Fix vlapic.h type

To: Patrick Colp <Patrick.Colp@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]Fix vlapic.h type
From: Neil Turton <nturton@xxxxxxxxxxxxxx>
Date: Wed, 08 Jul 2009 10:15:18 +0100
Cc: Wei Huang <wei.huang2@xxxxxxx>, "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 08 Jul 2009 02:15:44 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A544B76.6000304@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4A53BC08.1040100@xxxxxxx> <4A544B76.6000304@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Patrick Colp wrote:
> Good catch. This line:
> 
>   #define vlapic_vcpu(vpic)   (container_of((vpic), struct vcpu, \
>                                             arch.hvm_vcpu.vlapic))
> 
> should probably also be changed to this:
> 
>   #define vlapic_vcpu(vlapic)   (container_of((vlapic), struct vcpu, \
>                                               arch.hvm_vcpu.vlapic))

I'm not sure.  Do you intend to change the member name after hvm_vcpu
based on the macro parameter?

Cheers, Neil.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel